Add to CI check for specification version. #1760
Conversation
|
First, thank you to @jku for making it so easy to do. Some additional information: I run the tests on my forked repo. I decided not to add any version information to not make the issue obsolete in case of a new version. |
Pull Request Test Coverage Report for Build 1681675567
💛 - Coveralls |
|
The CI failure is fixed in #1762. |
There was a problem hiding this comment.
I think this is good enough, thanks.
I'm a bit on the fence about output (both logging and the issue message): It says what was done but includes nothing that would help debugging if things break (like the actual version strings that were compared)...
So, approving as is but please have a look at the logging/output: if you think it needs work we can do that
| console.log("Specification version does not match...") | ||
| const repo = context.repo.owner + "/" + context.repo.repo | ||
| const issues = await github.rest.search.issuesAndPullRequests({ | ||
| q: "specification+has+new+version+in:title+state:open+type:issue+repo:" + repo, |
There was a problem hiding this comment.
I'm guessing the "in:title" search might actually require quotes to get an exact search string but I think I'm fine with this: let's have another look if we get false positives in this.
This commit adds to the CI an automatic check for the TUF specification version and compares it with the python-tuf metadata API version. If the version does not match and there is not a issue already open, a new issue is opened. Closes theupdateframework#1598 Signed-off-by: Kairo de Araujo <[email protected]>
Fix query syntax that was missing the repository parameter Signed-off-by: Kairo de Araujo <[email protected]>
Minor changes to the console logs add versioning and simplify when they are logged. Signed-off-by: Kairo de Araujo <[email protected]>
kairoaraujo
force-pushed
the
issue#1598/automated_issue_spec_version
branch
from
c540f59
to
852bd02
Compare
read the contents and write (open) issues Signed-off-by: Kairo de Araujo <[email protected]>
This commit adds to the CI an automatic check for the TUF
specification version and compares it with the python-tuf metadata
API version.
If the version does not match and there is not a issue already open,
a new issue is opened.
Closes #1598
Signed-off-by: Kairo de Araujo [email protected]